Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @rowdepths to Alignment #2536

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

xworld21
Copy link
Contributor

Following up on #2488 (comment), simply record @rowdepths among the data collected by Alignment.

@dginev dginev requested a review from brucemiller March 23, 2025 16:06
Copy link
Owner

@brucemiller brucemiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We may want to followup later distinguishing total-height from height, and possibly this gives us a better handle on (& alternative to) rowspacing. But for now, this is good! Thanks!

@brucemiller brucemiller merged commit b5d5ffe into brucemiller:master Mar 24, 2025
13 checks passed
@xworld21 xworld21 deleted the rowdepths branch March 24, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants