Frankfurter update #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

terzioglub merged 16 commits into bruin-data:main from jbrand-dsp:frankfurter-update

May 2, 2025

Contributor

jbrand-dsp commented Apr 15, 2025

Adding the following for Frankfurter:

updated validation checks
integration tests
updated documentation

jbrand-dsp added 7 commits

April 12, 2025 17:35


          added test for validate_dates'

86582e3


          added some test for frankfurter

ff45f08


          test

5dee1ba


          integration tests all passing successfully

de399e0


          minor update in description of functionality

4478fe5


          deleted old helpers_test

c1cb437


          reverted requirements.txt

turtleDev reviewed

View reviewed changes

docs/supported-sources/frankfurter.md Outdated Show resolved Hide resolved

turtleDev reviewed

View reviewed changes

ingestr/src/frankfurter/helpers.py Outdated Show resolved Hide resolved

turtleDev reviewed

View reviewed changes

ingestr/main_test.py Outdated Show resolved Hide resolved

turtleDev reviewed

View reviewed changes

ingestr/main_test.py Outdated Show resolved Hide resolved

turtleDev reviewed

View reviewed changes

docs/supported-sources/frankfurter.md Outdated Show resolved Hide resolved

jbrand-dsp added 2 commits

April 24, 2025 10:19


          implemented feedback from PR review

dc0e1dc


          reformatting and integration of feedback from PR review

060eece

jbrand-dsp commented

View reviewed changes

ingestr/src/frankfurter/__init__.py Outdated Show resolved Hide resolved

jbrand-dsp force-pushed the frankfurter-update branch from 27d2cf5 to 060eece Compare

April 29, 2025 10:08

jbrand-dsp added 5 commits

April 29, 2025 12:44


          resolved merge conflicts

0fcc413


          added pulled changes

386e9a2


          minor change to md and revert requirements.txt

a3e74e1


          replaced unnecessary check with ignore

daf9414


          removed tz assignment

89d8d30

turtleDev reviewed

View reviewed changes

ingestr/src/frankfurter/__init__.py Outdated Show resolved Hide resolved

turtleDev reviewed

View reviewed changes

ingestr/src/frankfurter/__init__.py Outdated Show resolved Hide resolved

turtleDev reviewed

View reviewed changes

ingestr/src/frankfurter/__init__.py Outdated Show resolved Hide resolved

jbrand-dsp and others added 2 commits

May 2, 2025 15:19


          Update ingestr/src/frankfurter/__init__.py

35e99f0

Co-authored-by: Saravjeet 'Aman' Singh <[email protected]>


          Update ingestr/src/frankfurter/__init__.py

3e12ef7

Co-authored-by: Saravjeet 'Aman' Singh <[email protected]>

turtleDev approved these changes

View reviewed changes

terzioglub merged commit b96d064 into bruin-data:main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet