Skip to content

created function to abbreviate team names#401

Merged
ipark15 merged 1 commit into
developmentfrom
394-map-official-name-to-abbreviation
Apr 8, 2026
Merged

created function to abbreviate team names#401
ipark15 merged 1 commit into
developmentfrom
394-map-official-name-to-abbreviation

Conversation

@ipark15
Copy link
Copy Markdown
Collaborator

@ipark15 ipark15 commented Apr 7, 2026

No description provided.

@ipark15
Copy link
Copy Markdown
Collaborator Author

ipark15 commented Apr 7, 2026

can take a look at abbreviations to see if something else is preferred. ex: UCSB vs. UC Santa Barbara

@Fredenck
Copy link
Copy Markdown
Collaborator

Fredenck commented Apr 7, 2026

nice work, do you think we wanna have abbreviations on the dashboard or nah?

@Fredenck
Copy link
Copy Markdown
Collaborator

Fredenck commented Apr 7, 2026

i think we can keep the dashboard as-is. just one more thing I want to check on is UCSB's display name in dashboard has the (M) for some reason. Any clues why?

image

@ipark15
Copy link
Copy Markdown
Collaborator Author

ipark15 commented Apr 7, 2026

I had a similar problem when doing the abbreviations, and I think it has to do with how the data is stored. It might be the database has University of California, Santa Barbara (M) (M), so it only strips one of the M's, but not fully sure though. Are you able to check for this on your end before I make any changes?

@Fredenck
Copy link
Copy Markdown
Collaborator

Fredenck commented Apr 7, 2026

nice catch, yep I think someone uploaded the team incorrectly. fyi how it works is:

in /upload-team, people can add a team to the database. Before adding, we have a mini modification that creates two entries in the db, "{name} (M)" and "{name} (W)". generally all of this is hidden from the user but is accessible when uploading matches etc. looks like someone added name=ucsb (M) so it appended (M) and (W) twice

(more random fyi) How I fixed this:

  • go into/teams in the db and manually fix the name
  • go into each of the UCSB matches and manually fix the opponent name cuz it's stored as a string. in practice, this should be a foreign key/reference (you'll prob learn about it in 143 if you haven't seen it before)

speaking of foreign key/reference etc, I made a new issue about this #403 ; if ur interested in that kind of work (more system design/db schema/backend infra) feel free to pick it up

@Fredenck Fredenck assigned Fredenck and unassigned Fredenck Apr 7, 2026
@Fredenck Fredenck self-requested a review April 7, 2026 23:48
Copy link
Copy Markdown
Collaborator

@Fredenck Fredenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ipark15
Copy link
Copy Markdown
Collaborator Author

ipark15 commented Apr 8, 2026

sounds good!

@ipark15 ipark15 merged commit a82e93b into development Apr 8, 2026
1 check passed
@ipark15 ipark15 deleted the 394-map-official-name-to-abbreviation branch April 8, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants