a11y: Critical VoiceOver labels for icon/color-only UI#5
Closed
bruschill wants to merge 1 commit into
Closed
Conversation
Expose meaning that was previously conveyed only visually: - Message status badges (PKI-encrypted lock, XEdDSA-signed shield, store-forward envelope) plus detection-sensor and translate overlays now have labels. - LoRaSignalStrengthIndicator gains label + value, mirroring the BLE indicator. - Position-precision sliders (MQTT, ChannelForm) announce their value and hide the decorative plus/minus marker images from VoiceOver. - Purge-stale-nodes days slider announces a plural-aware day count. - Destructive crypto buttons (delete key backup, regenerate private key) get labels instead of reading as raw SF Symbol names. Refactors the message badge tuple into an Identifiable CornerBadge struct (resolves a large_tuple lint) with a stable id. Adds 10 source keys.
Owner
Author
|
Superseded by upstream meshtastic#2124 (reopened against upstream with the project PR template). Closing this staging PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Critical semantic accessibility labels from the audit — cases where meaning was conveyed to sighted users by icon/color only and was completely invisible to VoiceOver.
This is PR 1 of an accessibility initiative. It is stacked on #4 (base branch
a11y/pr2-localization) because it shares the String Catalog andMQTTConfig.swift— review/merge #4 first, or review this diff against that base.Changes
Images with no label. Refactored the badge tuple into anIdentifiable CornerBadgestruct (resolves alarge_tuplelint; stableid) and added.accessibilityLabels..accessibilityElement(children: .ignore)+ label + value.%lld daysis plural-aware, matching the siblingAfter %lld Days).Verification
BUILD SUCCEEDED(iPhone 17 Pro sim)large_tuple)Notes
skip-docs-check.