-
Notifications
You must be signed in to change notification settings - Fork 30
Fix typos #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #42
Conversation
|
A lot of files are changed here, sorry! |
bryanwweber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the thorough proof-reading! Based on the discussion in the related issue, I made a few suggestions and marked 👍 on the changes I think make sense to keep as-is. That said, I bet there are cases where I was inconsistent with the advice from the style manuals in the other direction (that is, I incorrectly capitalized in a few cases). I don't expect you to go through and look for those, though 😄
| 1. Fixed in space, with its origin at the center of the earth—the geocentric equatorial coordinate system, $X$, $Y$, and $Z$ | ||
| 2. Rotating at the same rate as the earth, with its origin at the center of the earth—the Earth-centered, Earth-fixed (ECEF) frame, $x'$, $y'$, and $z'$ | ||
| 1. Fixed in space, with its origin at the center of the Earth—the geocentric equatorial coordinate system, $X$, $Y$, and $Z$ | ||
| 2. Rotating at the same rate as the Earth, with its origin at the center of the Earth—the Earth-centered, Earth-fixed (ECEF) frame, $x'$, $y'$, and $z'$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emphasizing the acronym here.
| 2. Rotating at the same rate as the Earth, with its origin at the center of the Earth—the Earth-centered, Earth-fixed (ECEF) frame, $x'$, $y'$, and $z'$ | |
| 2. Rotating at the same rate as the earth, with its origin at the center of the earth—the Earth-Centered, Earth-Fixed (ECEF) frame, $x'$, $y'$, and $z'$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to your suggestion, except I kept "Earth" capitalized in all instances in that sentence.
|
@bryanwweber Thanks for your comment about Chicago and MLA. I am aware of those standards, but since this is an astrodynamics guide, not a liberal arts paper, I think that there are better style guides to use than MLA or Chicago, which are not typically used for scientific or engineering texts.
(They do not specifically call out rules related to other celestial bodies.)
As such, I stick by my capitalization of Moon, Earth, and Sun. Please read the above and let me know what you think. |
|
Thanks @NattyBumppo ! Those do seem more authoritative in this situation. I appreciate the thorough research; I'm annoyed and embarrassed that they didn't show up in my search! I resolved all the unnecessary comments, if you want to resolve the one remaining and pull over the |
Changed Low Earth Orbit capitalization. Co-authored-by: Bryan Weber <[email protected]>
|
Okay, I think all of my changes are in now. Please confirm @bryanwweber |
|
Sorry it's taking so long for me to get back to you here @NattyBumppo ! Just been very busy, I haven't forgotten about this 😁 |
No worries @bryanwweber . I'm reading through your book chapter by chapter and finding little minor corrections here and there. It's been a good way to brush up on my rusty astro knowledge. I'll have another PR for you before too long so I hope you don't mind 😅 |
Fixes #41 .