Fix sum and subtraction for Tensor with same inds but different permutation
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 84.35% 84.54% +0.19%
==========================================
Files 11 11
Lines 639 647 +8
==========================================
+ Hits 539 547 +8
Misses 100 100 ☔ View full report in Codecov by Sentry. |
mofeing
reviewed
Mar 20, 2024
test/Numerics_test.jl
Outdated
Comment on lines
10
to
14
| @test issetequal(size(C), (2, 3, 2)) | ||
|
|
||
| D = A - B | ||
| @test issetequal(inds(D), (:i, :j, :k)) | ||
| @test issetequal(size(D), (2, 3, 2)) |
There was a problem hiding this comment.
You should also test the result.
mofeing
reviewed
Mar 20, 2024
Co-authored-by: Sergio Sánchez Ramírez <[email protected]>
mofeing
approved these changes
Mar 20, 2024
mofeing
requested changes
Mar 20, 2024
mofeing
requested changes
Mar 20, 2024
Co-authored-by: Sergio Sánchez Ramírez <[email protected]>
mofeing
approved these changes
Mar 20, 2024
|
Can we merge this, @mofeing ? |
|
Yep, I approved it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #136. Additionally, we add some small tests to cover for the changes.