Add missing kwargs... in evolve-related functions

[jofrevalles]

This PR includes changes to evolve-related functions to add support for additional keyword arguments (kwargs...) in several functions. This enhancement allows for more flexible function calls by passing extra parameters as needed.

This is useful for example when we want to pass a kwarg into truncate.

[mofeing]

I totally prefer using kwargs... more often, but keep in mind that due to its nature it can affect many levels of calls of methods.

The changes I propose in the review are mainly the following:

• If threshold, maxdim and normalize are not directly used, but just passed, then remove them and let's pass them as part of kwargs.
• If you just need to know if threshold and maxdim are defined (i.e. the are not nothing), then use !isnothing(get(kwargs, :threshold, nothing))
  • What do you think about moving this check to truncate!? like make threshold=nothing and maxdim=nothing by default in truncate! and do the check also there. If I recall correctly, we don't do the check there and that's why we must do it here. I think it will look cleaner that way.
• If you need to override values from kwargs and ensure some kwarg configuration, then call do kwargs... first and then do the override.

[jofrevalles]

• What do you think about moving this check to truncate!? like make threshold=nothing and maxdim=nothing by default in truncate! and do the check also there. If I recall correctly, we don't do the check there and that's why we must do it here. I think it will look cleaner that way

I agree, this makes sense! I will do that.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 0.04%. Comparing base (0ba1707) to head (c4d3c2f).
Report is 12 commits behind head on master.

Files with missing lines	Patch %	Lines
src/MPS.jl	0.00%	20 Missing ⚠️
src/Ansatz.jl	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #267       +/-   ##
==========================================
- Coverage   79.59%   0.04%   -79.55%     
==========================================
  Files          32      32               
  Lines        2068    2150       +82     
==========================================
- Hits         1646       1     -1645     
- Misses        422    2149     +1727     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jofrevalles]

Okay @mofeing let's merge this

[mofeing]

super, just some lil suggestions and we're done

[mofeing]

just an aesthetic recommendation

Suggested change

	return tn
	else
	return truncate!(form(tn), tn, bond; threshold, maxdim, kwargs...)
	end
	return tn
	end
	return truncate!(form(tn), tn, bond; threshold, maxdim, kwargs...)

[mofeing]

probably better if you move this check to truncate_sweep! as you've done with truncate!

[jofrevalles]

Well okay, but I still need to check that is some way to normalize if it is not truncated.

[mofeing]

here the default is false but NonCanonical is true?
we must keep consistent

[jofrevalles]

Well okay, but this does not change anything, since we send normalize with default=true in evolve(ψ::AbstractAnsatz, mpo::AbstractMPO; reset_index=true, kwargs...).

[mofeing]

same as above