Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor contract in Reactant integration to use dot_general and test it #268

Merged
merged 18 commits into from
Dec 11, 2024

Conversation

mofeing
Copy link
Member

@mofeing mofeing commented Dec 7, 2024

stablehlo.einsum is deprecated. stablehlo.unary_einsum was deprecated and it's already removed, so we don't have any replacement right now but we will be able to write sth in the future based on stablehlo.reduce once the Ops is implemented.

@mofeing mofeing changed the title Update Reactant integration and test it Update contract in Reactant integration and test it Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 0.04%. Comparing base (0ba1707) to head (23d886f).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
ext/TenetReactantExt.jl 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #268       +/-   ##
==========================================
- Coverage   79.59%   0.04%   -79.55%     
==========================================
  Files          32      32               
  Lines        2068    2144       +76     
==========================================
- Hits         1646       1     -1645     
- Misses        422    2143     +1721     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofeing mofeing requested a review from jofrevalles December 10, 2024 14:19
@mofeing mofeing marked this pull request as ready for review December 10, 2024 14:19
@mofeing mofeing linked an issue Dec 10, 2024 that may be closed by this pull request
@mofeing mofeing changed the title Update contract in Reactant integration and test it Refactor contract in Reactant integration to use dot_general and test it Dec 10, 2024
@mofeing mofeing linked an issue Dec 10, 2024 that may be closed by this pull request
@mofeing mofeing merged commit 9c421c1 into master Dec 11, 2024
5 checks passed
@mofeing mofeing deleted the update-reactant branch December 11, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReactantExt: Einsum -> DotGeneral Test against Reactant
2 participants