Refactor inds(::Tensor) to return Tuple
#271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofeing
force-pushed
the
refactor/tensor-inds-tuple
branch
2 times, most recently
from
4780e61 to
cf1e00f
Compare
mofeing
force-pushed
the
refactor/tensor-inds-tuple
branch
from
7b48e15 to
ec86df9
Compare
jofrevalles
approved these changes
Jan 9, 2025
mofeing
force-pushed
the
refactor/tensor-inds-tuple
branch
from
ec86df9 to
76f22e1
Compare
|
Currently, only Reactant is failing. Core tests are passing which should be the only ones affected by this PR, so I'm merging. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
=========================================
- Coverage 0.04% 0.04% -0.01%
=========================================
Files 32 33 +1
Lines 2146 2181 +35
=========================================
Hits 1 1
- Misses 2145 2180 +35 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of
inds(::Tensor)is to return theVector{Symbol}, but this has the problem that mutating will modify the one from the original tensor too.