Fix tensor-number multiplication #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todorbsc
changed the title
jofrevalles
approved these changes
Jan 16, 2025
mofeing
requested changes
Jan 16, 2025
test/Numerics_test.jl
Outdated
Comment on lines
19
to
28
| @testset "tensor-number multiplication" begin | ||
| data = rand(2, 3, 4) | ||
| realnum = 2 | ||
| complexnum = 2 + 2im | ||
|
|
||
| A = Tensor(data, (:i, :j, :k)) | ||
| @test data * realnum ≈ parent(A * realnum) ≈ parent(realnum * A) | ||
| @test data * complexnum ≈ parent(A * complexnum) ≈ parent(complexnum * A) | ||
| end | ||
|
|
There was a problem hiding this comment.
this is just an alias to contract, can you put it inside the contract testset? name the testset "* alias"
There was a problem hiding this comment.
Done! check it out
mofeing
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a bug where the type
Tdoes NOT exist but it should be typeTensorin multiplication operation.