Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python environment and integration tests for Python extensions #300

Merged
merged 17 commits into from
Jan 22, 2025
Merged

Fix Python environment and integration tests for Python extensions #300

merged 17 commits into from
Jan 22, 2025

Conversation

Todorbsc
Copy link
Contributor

  • Python environment is not being created with the required dependencies for the Tenet-Python extensions and Python integration tests cannot run properly
  • Some Python integration tests gave errors when the environment issue was resolved

@Todorbsc Todorbsc added bug Something isn't working ci/cd Continuous Integration / Continuous Deployment labels Jan 20, 2025
@Todorbsc Todorbsc requested a review from mofeing January 20, 2025 16:02
@Todorbsc Todorbsc self-assigned this Jan 20, 2025
@Todorbsc Todorbsc requested a review from jofrevalles January 20, 2025 16:04
mofeing
mofeing requested changes Jan 20, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.09%. Comparing base (f2abea6) to head (212968a).
Report is 58 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #300       +/-   ##
===========================================
+ Coverage    0.04%   84.09%   +84.04%     
===========================================
  Files          32       36        +4     
  Lines        2146     2364      +218     
===========================================
+ Hits            1     1988     +1987     
+ Misses       2145      376     -1769

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mofeing
mofeing approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@mofeing mofeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything good! thanks @Todorbsc!

remember to reenable all the other tests, and do a SQUASH MERGE

@Todorbsc Todorbsc merged commit 5565285 into master Jan 22, 2025
7 checks passed
@Todorbsc Todorbsc deleted the fix/pythoncall-env branch January 22, 2025 21:47
@Todorbsc Todorbsc mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofeing mofeing mofeing approved these changes

@jofrevalles jofrevalles jofrevalles approved these changes

Assignees

@Todorbsc Todorbsc

Labels
bug Something isn't working ci/cd Continuous Integration / Continuous Deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Todorbsc @mofeing @jofrevalles