Open
Conversation
kinow
commented
Jul 5, 2022
Author
kinow
left a comment
There was a problem hiding this comment.
First PR to compss. Haven't learned how to run the tests, so didn't check that option in the pull request template. Hoping CI will find any issues with this PR 👍
| ] | ||
|
|
||
| TARGET_OS = os.environ["TARGET_OS"] | ||
| TARGET_OS = platform.system() |
Author
There was a problem hiding this comment.
I wasn't sure if there was a reason for using this environment variable, but if it's legacy code, then maybe the platform module is a more suitable option? The TARGET_OS is not defined in my env.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request template
about: Fix typo, use the
platformmodule for OS detectiontitle: ''
labels: ''
assignees: ''
Status
READY
Description
Hi, this PR does not fix any existing issue. I cloned the project, imported the Java project in Eclipse, and the Python binding in PyCharm. PyCharm found a few issues, and I also couldn't install it with
pip install -e .(now it's failing with another error, but no Python traceback).Type of change
Please delete options that are not relevant.
Project impact
List the general project components that this PR will affect:
Related PRs
How Has This Been Tested?
Checklist:
utils/scripts/header_setup/replace_all.sh)