Skip to content

v0.6.10 - Calendar and settings escaping, threshold cap - #156

Closed
bscott wants to merge 6 commits into
mainfrom
auto/adoring-fermat-d8uzgh
Closed

bscott wants to merge 6 commits into
mainfrom
auto/adoring-fermat-d8uzgh

Conversation

@bscott

@bscott bscott commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

Test Plan

  • go build ./... && go vet ./... && go test ./...
  • New Playwright tests for calendar names, calendar icon URLs and settings category names. The name tests fail on main and pass here.
  • Full Chromium Playwright suite: 46/46 pass
  • New handler test for threshold values (500000, 0, -1, +Inf, NaN, abc)
  • Smoke test: a 500000 VND threshold saves and shows as 500000

Closes #154
Closes #155


claude and others added 5 commits October 18, 2026 07:16
Fixes #154.

Calendar day cells are built as HTML strings, but subscription names,
icon URLs and currency symbols only had quotes escaped, so markup in a
name was rendered. Escape &, <, >, " and ' with one helper for every
interpolated value, and coerce the event id to a number.
Fixes #155.

The threshold is in the instance currency, so the fixed 10000 limit was
far too low for currencies like VND or KRW. Drop the upper bound in the
input and the handler (still rejecting negative, infinite and non-numeric
values), and show the value with currency-aware decimals.
The settings page renders categories with innerHTML and interpolated
category names unescaped, both as text and in the edit input's value, so
markup in a name was rendered. Escape names with the same helper as the
calendar and coerce ids to numbers. Also cover icon URLs in the calendar
escaping test.
Point vulnerability reports at security@byte-mail.xyz and state what is
in scope, so the contact can be verified from the repository.
.oss-scanner/Dockerfile builds both binaries with debug info, warms the
module and test caches, and runs the Go suite so Anthropic's OSS Scanner
can audit the project offline. threat_model.md describes the trust model,
where untrusted input enters, and how we rate severity.
@claude

claude Bot commented Oct 20, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@bscott bscott self-assigned this Oct 20, 2026
@bscott bscott closed this Oct 20, 2026
@bscott
bscott deleted the auto/adoring-fermat-d8uzgh branch October 20, 2026 02:29
@bscott

bscott commented Oct 20, 2026

Copy link
Copy Markdown
Owner Author

Closed automatically when the head branch was renamed to v0.6.10. Continued in #157 with the same commits plus the template cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

High-cost threshold is capped at 10000 regardless of currency Calendar view does not HTML-escape subscription names

2 participants