Repository navigation
Conversation
Fixes #154. Calendar day cells are built as HTML strings, but subscription names, icon URLs and currency symbols only had quotes escaped, so markup in a name was rendered. Escape &, <, >, " and ' with one helper for every interpolated value, and coerce the event id to a number.
Fixes #155. The threshold is in the instance currency, so the fixed 10000 limit was far too low for currencies like VND or KRW. Drop the upper bound in the input and the handler (still rejecting negative, infinite and non-numeric values), and show the value with currency-aware decimals.
The settings page renders categories with innerHTML and interpolated category names unescaped, both as text and in the edit input's value, so markup in a name was rendered. Escape names with the same helper as the calendar and coerce ids to numbers. Also cover icon URLs in the calendar escaping test.
Point vulnerability reports at security@byte-mail.xyz and state what is in scope, so the contact can be verified from the repository.
.oss-scanner/Dockerfile builds both binaries with debug info, warms the module and test caches, and runs the Go suite so Anthropic's OSS Scanner can audit the project offline. threat_model.md describes the trust model, where untrusted input enters, and how we rate severity.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
5 tasks done
Owner
Author
|
Closed automatically when the head branch was renamed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SECURITY.mdwith the security contact (security@byte-mail.xyz) and scope..oss-scanner/Dockerfileand.oss-scanner/threat_model.mdfor enrolling SubTrackr in Anthropic's OSS Scanner.Test Plan
go build ./... && go vet ./... && go test ./...mainand pass here.500000Closes #154
Closes #155