Repository navigation
Conversation
The webServer command pointed at 'go run .', which has no main package, so the suite only worked against a manually started server. Start cmd/server on :8082 with a fresh test-data/e2e.db per run, wait on /healthz, and allow PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH to reuse a preinstalled Chrome. Amp-Thread-ID: https://ampcode.com/threads/T-01a15d11-e6c5-744b-a0f0-14abda7f49c0 Co-authored-by: Amp <amp@ampcode.com>
…spec - web/static/category-management.js and web/static/js/darkmode.js are not loaded by any template (superseded by inline settings script and themes.js) - .playwright-mcp/*.png were scratch MCP screenshots (folder is gitignored) - darkmode-screenshot.png is not referenced by README - tests/example.spec.js is the Playwright starter test Amp-Thread-ID: https://ampcode.com/threads/T-01a15f13-74f2-77eb-9ab8-8eb6bf4e6d9f Co-authored-by: Amp <amp@ampcode.com>
Untrack .beads/dolt-monitor.pid, dolt-server.port, dolt-server.activity and backup/, and ignore them. issues.jsonl, interactions.jsonl and hooks/ stay. Amp-Thread-ID: https://ampcode.com/threads/T-01a15f13-74f2-77eb-9ab8-8eb6bf4e6d9f Co-authored-by: Amp <amp@ampcode.com>
Reported by 'go run golang.org/x/tools/cmd/deadcode@latest -test ./...': - service/logo.go: GetLogoURL, ValidateLogoURL, FetchAndValidateLogo, ExtractDomain, DownloadLogo - service/session.go: RefreshSession, UpdateSessionExpiry, GetSession - service/currency.go: GetExchangeRate, RefreshRates - repository/exchange_rate.go: GetLatestRates, DeleteStaleRates - service/category.go: GetByID, GetByName; repository/category.go: GetByName - service+repository/subscription.go: Count - service+repository/tag.go: GetAll - handlers/subscription.go: formatCurrency Amp-Thread-ID: https://ampcode.com/threads/T-01a15f13-74f2-77eb-9ab8-8eb6bf4e6d9f Co-authored-by: Amp <amp@ampcode.com>
src/, public/, tsconfig.json, tailwind.config*, postcss.config*, rebuild.sh and remove-configs.sh no longer exist. Keep node_modules/ and package*.json, which still match the Playwright tooling. Amp-Thread-ID: https://ampcode.com/threads/T-01a15f13-74f2-77eb-9ab8-8eb6bf4e6d9f Co-authored-by: Amp <amp@ampcode.com>
…shots/ folder The two page.screenshot calls wrote screenshots/v0.6.0-*.png into the repo on every run and asserted nothing. Amp-Thread-ID: https://ampcode.com/threads/T-01a15f13-74f2-77eb-9ab8-8eb6bf4e6d9f Co-authored-by: Amp <amp@ampcode.com>
…ated server Optional login, password reset, clear-all, backup/restore and the Wallos import change global server state, so they cannot share the :8082 server the other specs use in parallel. Add an 'isolated' Playwright project (workers: 1) that runs tests/isolated-*.spec.js against a second cmd/server on :8083 with its own test-data-isolated/ database; the other projects ignore those files. Password reset emails go to a small in-process SMTP sink that speaks STARTTLS with a self-signed localhost certificate, which the :8083 server trusts through SSL_CERT_FILE. Behaviour that is broken today is marked test.fail(): - login and reset-password errors are 4xx responses that htmx 1.9 does not swap, so users never see them - reminder_enabled=false is lost on Wallos import and backup restore (GORM default:true overrides the false zero value) Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a15f14-5ccb-754d-9e60-bddee9aef880
Add Playwright coverage for SMTP, Pushover, Webhook and Telegram config, notification toggles, reminder windows and threshold, currency, date format, language, theme, categories, API keys, the iCal feed and the base URL. The specs run against a per-worker server with its own database (tests/helpers/settings-server.js) because these settings are global and notification channel configs cannot be cleared through the API. test.fail() marks 8 error-message cases that HTMX 1.9 does not swap (should pass after HTMX 4) and 5 app bugs. Amp-Thread-ID: https://ampcode.com/threads/T-01a15f14-4298-7204-abc5-4b0aac43acaf Co-authored-by: Amp <amp@ampcode.com>
… /api/v1 Adds Playwright regression coverage for the read-only pages, data export and the public API ahead of the HTMX 4 upgrade. Assertions use rendered text, HTTP output and data the tests create, so they do not depend on htmx internals or on other specs' data. Known bugs are marked test.fail(): calendar leading days come from the wrong month, iCal TEXT values are not escaped, /api/v1 ignores the JSON bodies the README documents, subscription validate rules are never enforced, and the create response carries an empty category. Amp-Thread-ID: https://ampcode.com/threads/T-01a15f14-510a-7109-aae6-6fa5fa033b34 Co-authored-by: Amp <amp@ampcode.com>
…ules and statuses Playwright regression net for the HTMX 4 upgrade. Assertions use the DOM, URLs and API state only. Known-broken behaviour is marked test.fail(): - form errors (400 + HX-Retarget) are not shown with HTMX 1.9 - reminders unchecked on create are saved enabled (GORM default:true) - the search 'no matches' message is hidden again by the sort swap's settle Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a15f14-39b4-74ee-b677-480514b4f14e
Language is global server state and the suite runs in parallel against one server, so leaving it on 'es' could break English assertions in other specs. Amp-Thread-ID: https://ampcode.com/threads/T-01a15d11-e6c5-744b-a0f0-14abda7f49c0 Co-authored-by: Amp <amp@ampcode.com>
…ings The token inputs are now always empty and show a "Token saved" placeholder when a token is stored. Save and Test fall back to the stored token when the field is blank; first-time setup still requires it. Amp-Thread-ID: https://ampcode.com/threads/T-01a15f88-1541-74ab-8927-72b4027f07bc Co-authored-by: Amp <amp@ampcode.com>
GORM substitutes a field's default:true for the false zero value on Create, so subscriptions created with reminders off (form, /api/v1, Wallos import, backup restore, duplicate) were saved with reminders on. Drop the gorm default from Subscription.ReminderEnabled. Create paths already default it to true when the caller does not send it (form and API handler); MCP create now sets it, and restore pre-sets it before decoding each entry so old backups without the field keep reminders on. Restore now parses every entry before replace mode deletes data. AutoMigrate rebuilds the subscriptions table once to drop the column default; existing values are kept. Removes test.fail() from the three Playwright specs for this bug and adds a repository regression test. Amp-Thread-ID: https://ampcode.com/threads/T-01a15f88-1e1d-76be-83b5-0e6c8d31b4ff Co-authored-by: Amp <amp@ampcode.com>
PRAGMA foreign_keys ran on a single pooled connection, so FK enforcement depended on which connection served a query, and with no busy_timeout concurrent writers (reminder scheduler, parallel requests) failed with "database is locked". Pass _foreign_keys, _busy_timeout=5000, _journal_mode=WAL and _txlock=immediate in the DSN so mattn/go-sqlite3 applies them to every connection. WAL adds -wal/-shm files next to the database in data/. Run migrations on one pinned connection with foreign keys off (and restored afterwards), so table rebuilds cannot fail on or cascade into subscription_tags. Adds tests for FK and WAL on several concurrent connections and for concurrent read-then-write transactions. Amp-Thread-ID: https://ampcode.com/threads/T-01a15f88-1e1d-76be-83b5-0e6c8d31b4ff Co-authored-by: Amp <amp@ampcode.com>
5 of 7 tasks
- Password reset links are built only from the configured Base URL - Email headers are stripped of line breaks and RFC 2047 encoded - Resolved email.go by keeping v0.7.0's To Cancel reminder and channel methods alongside the new header helpers
- API key create/delete errors render the message above the current keys instead of an empty list (htmx 4 swaps 4xx/5xx responses) - Trim API key names so whitespace-only names are rejected - Focus the Name field when the subscription form loads before the mobile menu opens the dialog
ubuntu-latest now resolves to Ubuntu 26.04, where Playwright 1.56.1 cannot install browser dependencies, so every E2E browser job failed during installation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up (
39138f7..09f99f1): merged main's v0.6.11 security fixes (password reset link poisoning, email header injection). A browser regression pass of the htmx 1.9 → 4 upgrade, covering every page and htmx endpoint, found two issues, both fixed with tests inee853ed. First, a failed API key create or delete replaced the key list with an empty one, because htmx 4 swaps error responses. Second, Add Subscription from the mobile menu did not focus the Name field.09f99f1pins the Playwright jobs toubuntu-24.04:ubuntu-latestnow resolves to Ubuntu 26.04, which Playwright 1.56.1 cannot install browsers on. All nine distinct CI checks pass on 09f99f1.Upgrade safety follow-up (
6d79d37): the additional full-PR Fable review found that GORM's automatic table rebuild reset deleted-ID history and dropped custom indexes on existing installations. The correction preserves schema metadata transactionally and verifies data counts, with rollback and process-death recovery tests using captured release schemas. Independent review found no blockers; stale sequence handling and single-column UNIQUE coverage were added. Build, vet and the full Go race suite pass. All nine distinct CI checks now pass on 6d79d37. Downloaded PR artifacts confirm 808 functional browser passes, 27 documented expected failures, zero unexpected failures, zero skips and zero flaky outcomes. The tested upgrade gate is satisfied; remaining deployment boundaries are documented.README now documents stopped full-directory backups, WAL storage requirements and rollback by restoring the prior backup. Tests cover captured v0.6.10 fresh and v0.3.0-to-v0.6.10 schemas plus two legacy shapes; the exploratory 63-path sweep is not claimed as committed reproducible coverage. Custom single-column UNIQUE indexes may cause a safe rebuild on each startup. Real long-lived database compatibility is not guaranteed.
Upgrades the application from HTMX 1.9 to vendored HTMX 4.0.0, adds DD.MM.YYYY dates, ntfy/Gotify delivery, and per-subscription To Cancel reminders with 3/5/14-day lead times. Cancellation intent respects notice deadlines, supports Active/Trial subscriptions, and records delivery only after a configured channel succeeds.
The browser audit also fixed calendar/iCal errors, tagged deletion and uncategorized subscriptions, MCP optional input schemas, modal/menu keyboard handling, theme persistence and mobile overflow. SQLite upgrades preserve tag links and AUTOINCREMENT history. Notification tests use local sinks; live Pushover tests now require explicit opt-in.
Validation: all nine distinct CI checks passed on implementation commit a470c25, including all six browser projects, MCP stdio, test-build and automated Claude review. Downloaded CI artifacts show 808 functional browser passes, 27 documented expected failures, zero unexpected failures, zero skips and zero flaky outcomes. The expected failures represent nine pre-existing public API defects exercised in three engines. Go build, vet and the full race suite also passed locally. Independent Claude Fable/Opus reviews completed and blocking findings were corrected. Linux/macOS targeted checks and mutation checks verified the final WebKit fixes. Final commit 27e2685 changes only beads completion metadata; application and tests are identical to a470c25. The PR remains draft for user review; no merge or release publication.
Known follow-ups are tracked in beads: public API JSON/validation issues already encoded as expected failures, channel disable controls, high-cost default consistency, live deadline preview, the remaining narrow user-save/delivery-state race, and expired-session export links potentially saving login/error content instead of redirecting (subtrackr-xyz-dxu). Expected failures will be reported separately from functional passes.
#150 is explicitly excluded; the license is unchanged. Release publication is not part of this PR work.
Closes #136
Closes #137
Closes #158
Closes #159