hiro/qt: Fixes for trivial Qt 5 deprecations #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enum was deprecated in Qt 4.8 and removed in Qt 6.0.
jchv
changed the title
jchv
changed the title
QFontMetrics::width was deprecated in Qt 5.11 in favor of Qt QFontMetrics::horizontalAdvance. Because QFontMetrics::horizontalAdvance was introduced in Qt 5.11, it poses the most risk of breaking an existing user of almost any of the deprecation changes, but Qt 5.11 is fairly old by now (2018) and has been EOL for a while, so I still opted to just move to the new function rather than use a version guard.
setMargin has been obsolete since Qt 4.3!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt::MidButton: This enum value was deprecated in Qt 4.8 and removed in Qt 6.x.QFontMetrics::width: This function was deprecated in Qt 5.11 and removed in Qt 6.x.QLayout::setMargin: This function was deprecated in Qt 4.3 (!) and removed in Qt 6.x.QPalette::Background: This enum value was deprecated sometime in Qt 4.0 and removed in Qt 6.x.There's still more clean-up that would be needed for Qt 6 support, including uses of
QApplication::desktop()andQApplication::hasPendingEvents(). The former I think can move toQScreenAPIs, the latter might require Hiro API changes (probably getting rid ofApplication::pendingEvents; nothing outside of Hiro seems to need it anyway.)