hiro/qt: Fix deprecated QWheelEvent->{delta,orientation}() usage #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The orientation() and delta() methods of QWheelEvent were deprecated in Qt 5.0 in favor of angleDelta(), which expresses higher-fidelity data for devices like trackpads. In order to keep the behavior 100% identical, the code used to calculate the orientation() and delta() values in Qt 5.15 is inlined instead. That logic can be seen here: https://github.com/qt/qtbase/blob/v5.15.17-lts-lgpl/src/gui/kernel/qevent.cpp#L876-L884 Following this logic, we also break the tie for orientation in favor of vertical scrolling. Since there is no actual HexEdit usage in bsnes, I tested it by putting a dummy HexEdit widget inside the bsnes Presentation window. Scrolling seemed to work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
orientation()anddelta()methods ofQWheelEventwere deprecated in Qt 5.0 in favor ofangleDelta(), which expresses higher-fidelity data for devices like trackpads. In order to keep the behavior 100% identical, the code used to calculate the orientation() and delta() values in Qt 5.15 is inlined instead. That logic can be seen here:https://github.com/qt/qtbase/blob/v5.15.17-lts-lgpl/src/gui/kernel/qevent.cpp#L876-L884
Following this logic, we also break the tie for orientation in favor of vertical scrolling.
Since there is no actual
HexEditusage in bsnes, I tested it by putting a dummyHexEditwidget inside the bsnes Presentation window. Scrolling seemed to work as expected.