Switch to private testnet and upgrade by napoly · Pull Request #105 · btcpay-monero/btcpayserver-monero-plugin

napoly · 2026-06-06T11:50:27Z

https://moneroexamples.github.io/private-testnet/

related to: btcpay-monero/monero-csharp#80

codacy-production · 2026-06-06T11:52:33Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results

Complexity 0

Duplication 0

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results

Coverage variation ✅ +0.00% coverage variation (-1.00%)

Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details

Coverable lines Covered lines Coverage

Common ancestor commit (3c59948) Report Missing Report Missing Report Missing

Head commit (cab1802) 828 (+0) 499 (+0) 60.27% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

Coverable lines Covered lines Diff coverage

Pull request (#105) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

¹ Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

nahuhh · 2026-06-06T12:16:22Z

Might make more sense to use regtest

edit: i just noticed that it was using regtest before.
i dont think it makes any sense to switch to testnet. iirc, youd also have to change the hard fork table, otherwise your private testnet will be using old fork rules. regtest uses the latest.

so, nack changing to a private testnet. All of this can be done more cleanly using a private regtest network.

nahuhh · 2026-06-08T10:07:02Z

-                    "43Pnj6ZKGFTJhaLhiecSFfLfr64KPJZw7MyGH73T6PTDekBBvsTAaWEUSM4bmJqDuYLizhA13jQkMRPpz9VXBCBqQQb6y5L",
-                viewkey = "1bfa03b0c78aa6bc8292cf160ec9875657d61e889c41d0ebe5c54fd3a2c4b40e",
+                    "9yEzCbcYdg6MqZ5AkEh8V3YCriyN1tvmtWEHdBEUHkF6D6kN1MMD2Kd2QVWoTY67aNHNYKMUP3xfteLS2QNavJxpJdx6mWj",
+                viewkey = "1f4668e8c1979b4c7dae13dc149fd95cd7ff2883becffe160c21f9e02c821c08",


Why not use regtest and leave these values unchanged?

nahuhh · 2026-06-08T10:07:30Z

-                "43Pnj6ZKGFTJhaLhiecSFfLfr64KPJZw7MyGH73T6PTDekBBvsTAaWEUSM4bmJqDuYLizhA13jQkMRPpz9VXBCBqQQb6y5L");
+                "9yEzCbcYdg6MqZ5AkEh8V3YCriyN1tvmtWEHdBEUHkF6D6kN1MMD2Kd2QVWoTY67aNHNYKMUP3xfteLS2QNavJxpJdx6mWj");
        await s.Page.Locator("input#PrivateViewKey")
-            .FillAsync("1bfa03b0c78aa6bc8292cf160ec9875657d61e889c41d0ebe5c54fd3a2c4b40e");
+            .FillAsync("1f4668e8c1979b4c7dae13dc149fd95cd7ff2883becffe160c21f9e02c821c08");


nahuhh · 2026-06-08T10:07:42Z

-            .FillAsync("1bfa03b0c78aa6bc8292cf160ec9875657d61e889c41d0ebe5c54fd3a2c4b40e");
+            .FillAsync("1f4668e8c1979b4c7dae13dc149fd95cd7ff2883becffe160c21f9e02c821c08");


nahuhh · 2026-06-08T10:07:59Z

-            PrimaryAddress = "43Pnj6ZKGFTJhaLhiecSFfLfr64KPJZw7MyGH73T6PTDekBBvsTAaWEUSM4bmJqDuYLizhA13jQkMRPpz9VXBCBqQQb6y5L",
-            PrivateViewKey = "1bfa03b0c78aa6bc8292cf160ec9875657d61e889c41d0ebe5c54fd3a2c4b40e",
-            WalletFileName = "wallet",
-            Password = ""
-        });
+        await moneroRpcProvider.WalletRpcClients["XMR"]
+            .SendCommandAsync<GenerateFromKeysRequest, GenerateFromKeysResponse>("generate_from_keys",
+                new GenerateFromKeysRequest
+                {
+                    PrimaryAddress =
+                        "9yEzCbcYdg6MqZ5AkEh8V3YCriyN1tvmtWEHdBEUHkF6D6kN1MMD2Kd2QVWoTY67aNHNYKMUP3xfteLS2QNavJxpJdx6mWj",
+                    PrivateViewKey = "1f4668e8c1979b4c7dae13dc149fd95cd7ff2883becffe160c21f9e02c821c08",


nahuhh · 2026-06-08T10:08:11Z

-            .FillAsync("43Pnj6ZKGFTJhaLhiecSFfLfr64KPJZw7MyGH73T6PTDekBBvsTAaWEUSM4bmJqDuYLizhA13jQkMRPpz9VXBCBqQQb6y5L");
+            .FillAsync("9yEzCbcYdg6MqZ5AkEh8V3YCriyN1tvmtWEHdBEUHkF6D6kN1MMD2Kd2QVWoTY67aNHNYKMUP3xfteLS2QNavJxpJdx6mWj");
        await s.Page.Locator("input#PrivateViewKey")
-            .FillAsync("1bfa03b0c78aa6bc8292cf160ec9875657d61e889c41d0ebe5c54fd3a2c4b40e");
+            .FillAsync("1f4668e8c1979b4c7dae13dc149fd95cd7ff2883becffe160c21f9e02c821c08");


nahuhh · 2026-06-08T10:09:01Z

+    container_name: node_1
+    command: [
+      "monerod",
+      "--fixed-difficulty=150",


I presume this is changed from 1 as to limit the block rate?

this a battle tested value from haveno-ts https://github.com/haveno-dex/haveno-ts/blob/master/docker/docker-compose.yml#L39 to mine blocks efficiently / in time

nahuhh · 2026-06-08T10:11:18Z

+      "--confirm-external-bind",
+      "--add-exclusive-node=node_2:28080",
+      "--block-notify=/bin/sh ./scripts/notifier.sh -k -X GET https://host.docker.internal:14142/monerolikedaemoncallback/block?cryptoCode=xmr&hash=%s",
+      "--testnet",


Suggested change

"--testnet",

"--regtest",

nahuhh · 2026-06-08T10:11:54Z

+      "--add-exclusive-node=node_2:28080",
+      "--block-notify=/bin/sh ./scripts/notifier.sh -k -X GET https://host.docker.internal:14142/monerolikedaemoncallback/block?cryptoCode=xmr&hash=%s",
+      "--testnet",
+      "--no-igd",


Suggested change

"--no-igd",

removed upstream in v0.18.5.0

can you pls bump ? https://github.com/btcpayserver/dockerfile-deps/tree/master/Monero https://github.com/btcpayserver/btcpayserver-docker/blob/master/docker-compose-generator/docker-fragments/monero.yml

nahuhh · 2026-06-08T10:14:09Z

+    command: [
+      "monero-wallet-rpc",
+      "--log-level=2",
+      "--allow-mismatched-daemon-version",


This is only needed if using --regtest

napoly · 2026-06-19T14:28:02Z

All of this can be done more cleanly using a private regtest network.

@nahuhh thanks for looking into this direction, you aren't the first one to question

The main reason for testnet over regtest is realism.. real PoW, nothing mocked away. It's 1:1 to production..

nahuhh · 2026-06-20T05:26:16Z

real PoW, nothing mocked away. It's 1:1 to production..

they both use real pow, but testnet uses v1 transactions, and probably not even randomx?

napoly · 2026-06-20T06:15:43Z

no need for randomx here.. i just need to pay for the invoice.. should be easy to switch/modify if we would need it tho

nahuhh · 2026-06-20T06:30:57Z

Yea.. you said that regtest doesnt use pow.. it does.. and, it uses the same pow as mainnet.

it also uses the same type of transactions.

your old setup had a fixed difficulty of 1, the new setup has a fixed difficulty of 100. They both use pow

napoly · 2026-06-20T06:34:46Z

but I also said it's 1:1 to prod.. testnet wont allow you to mine instantly for example.. (saves headache)

Skip password file test if not running in a container

ecd998a

napoly requested a review from deverickapollo June 6, 2026 12:34

Switch to private testnet and upgrade

cab1802

napoly force-pushed the switch-to-private-testnet branch from 070a249 to cab1802 Compare June 8, 2026 09:07

nahuhh reviewed Jun 8, 2026

View reviewed changes

		.FillAsync("1bfa03b0c78aa6bc8292cf160ec9875657d61e889c41d0ebe5c54fd3a2c4b40e");
		.FillAsync("1f4668e8c1979b4c7dae13dc149fd95cd7ff2883becffe160c21f9e02c821c08");

Conversation

napoly commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codacy-production Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

nahuhh commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

napoly commented Jun 19, 2026

Uh oh!

nahuhh commented Jun 20, 2026

Uh oh!

napoly commented Jun 20, 2026

Uh oh!

nahuhh commented Jun 20, 2026

Uh oh!

napoly commented Jun 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

napoly commented Jun 6, 2026 •

edited

Loading

codacy-production Bot commented Jun 6, 2026 •

edited

Loading

nahuhh commented Jun 6, 2026 •

edited

Loading