Skip to content

Add wallet management via ui#58

Open
deverickapollo wants to merge 1 commit into
masterfrom
add-wallet-replace
Open

Add wallet management via ui#58
deverickapollo wants to merge 1 commit into
masterfrom
add-wallet-replace

Conversation

@deverickapollo

Copy link
Copy Markdown
Member

No description provided.

@Kukks Kukks left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to say I love how dedicated you guys are with this development!

@codacy-production

codacy-production Bot commented Nov 11, 2025

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+8.04% (target: -1.00%) 73.75%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d61513b) 993 581 58.51%
Head commit (9807a32) 1366 (+373) 909 (+328) 66.54% (+8.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#58) 499 368 73.75%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@deverickapollo deverickapollo marked this pull request as ready for review November 11, 2025 05:45

@napoly napoly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should link the wallet with the generated invoice as we might end up in a mess.. this info might be beneficial for user as well as for the system itself. I also don't think this PR should be merged before #61 is resolved as anyone using a previously used wallet for invoice generation would get duplicate key constraint violation.

Comment thread BTCPayServer.Plugins.IntegrationTests/Monero/MoneroPluginIntegrationTest.cs Outdated
Comment thread Plugins/Monero/Services/MoneroRpcProvider.cs
Comment thread Plugins/Monero/Services/MoneroListener.cs
Comment thread Plugins/Monero/Controllers/MoneroLikeStoreController.cs Outdated
Comment thread Plugins/Monero/Services/MoneroRPCProvider.cs Outdated
Comment thread Plugins/Monero/Services/MoneroConfigurationMigrationService.cs Outdated
@napoly

napoly commented Mar 2, 2026

Copy link
Copy Markdown
Member

There’s a lot of good stuff in here.

I’m finding it really difficult to properly review 2k+ lines in one go, and I’m worried I won’t be able to give it the attention it deserves.

Would it be possible to split this into smaller, atomic PRs (wallet state, migration..) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants