Add wallet management via ui#58
Conversation
Kukks
left a comment
There was a problem hiding this comment.
Just wanted to say I love how dedicated you guys are with this development!
2c8738c to
068195e
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
napoly
left a comment
There was a problem hiding this comment.
This PR should link the wallet with the generated invoice as we might end up in a mess.. this info might be beneficial for user as well as for the system itself. I also don't think this PR should be merged before #61 is resolved as anyone using a previously used wallet for invoice generation would get duplicate key constraint violation.
068195e to
c14f84f
Compare
6f85edd to
653457a
Compare
653457a to
d00edb5
Compare
d00edb5 to
9807a32
Compare
|
There’s a lot of good stuff in here. I’m finding it really difficult to properly review 2k+ lines in one go, and I’m worried I won’t be able to give it the attention it deserves. Would it be possible to split this into smaller, atomic PRs (wallet state, migration..) ? |
No description provided.