Skip to content

Move Core Lightning maintenance instructions to image-maintenance - #6

Merged
NicolasDorier merged 1 commit into
btcpaymasterfrom
docs/image-maintenance
Nov 5, 2026
Merged

NicolasDorier merged 1 commit into
btcpaymasterfrom
docs/image-maintenance

Conversation

@NicolasDorier

@NicolasDorier NicolasDorier commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Remove fork-local AGENTS.md and the update-btcpay-cln skill after migrating their procedures to the shared maintenance repository.
  • Add a short README link so maintainers and agents can discover the new entry point.
  • Keep product patches, Dockerfiles, entrypoint and image publishing CI unchanged.

Dependency and related work

Merge btcpayserver/image-maintenance#1 first so the master links resolve. The centralized procedure incorporates applicable corrections from #5, including both downstream integration gates, per-platform source verification, generated Docker documentation and publication-aware recovery. This PR does not modify or close #5 or its branch.

Historical published tags remain unchanged. Future linear patch replay should carry functional patches, not the old instruction-only commit.

Validation

  • Pass git diff --check for this documentation-only change.
  • Preserve all fork build, runtime and CI files unchanged.
  • Validate destination documentation links and helpers in the parent repository tests.

No release branch rewrite, new image publication, downstream bump or live deployment was performed. The existing instructions PR #5 records unrelated ShellCheck failures in the unchanged entrypoint; this migration does not attempt to fix those.

Changelog-None

@NicolasDorier

Copy link
Copy Markdown
Member Author

Current-head CI reached source checks after the changelog exemption was added, then failed on the same existing entrypoint ShellCheck findings documented in #5:

  • tools/docker-entrypoint.sh:93:12 — SC1090
  • tools/docker-entrypoint.sh:114:16 — SC1090

Run: https://github.com/btcpayserver/lightning/actions/runs/41990684401

The entrypoint is unchanged by this documentation migration. I have not weakened CI or added unrelated runtime changes. The PR remains draft pending image-maintenance#1 and maintainer review of this existing CI blocker.

@NicolasDorier
NicolasDorier force-pushed the docs/image-maintenance branch from eab6419 to 62db460 Compare November 5, 2026 10:30
@NicolasDorier
NicolasDorier marked this pull request as ready for review November 5, 2026 10:31
@NicolasDorier

Copy link
Copy Markdown
Member Author

Squashed the cleanup to one commit and verified its final tree is unchanged. The shared repository is merged in btcpayserver/image-maintenance#1. Current CI run https://github.com/btcpayserver/lightning/actions/runs/42011335885 fails only on the same pre-existing SC1090 findings in unchanged tools/docker-entrypoint.sh lines 93 and 114. Nicolas explicitly requested merging the related PRs; proceeding with this documentation-only cleanup without changing runtime code or disabling checks.

@NicolasDorier
NicolasDorier merged commit 1ab6193 into btcpaymaster Nov 5, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant