Repository navigation
Update Docker startup - #15
Closed
r2ckstardev wants to merge 1 commit into
Closed
r2ckstardev wants to merge 1 commit into
r2ckstardev wants to merge 1 commit into
Conversation
r2ckstardev
force-pushed
the
fix/durable-wallet-password-migration
branch
from
September 14, 2026 05:43
7d2a039 to
4b1feac
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Recovery currently depends on an external Docker restart policy and can otherwise leave the container stopped.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Improves Docker recovery from interrupted wallet-password migrations while preserving wallet data and rotating macaroon credentials.
Changes:
- Adds atomic pending-password persistence and recovery.
- Recreates macaroon authentication data after interrupted migrations.
- Adds Docker-based regression scenarios.
File summaries
| File | Description |
|---|---|
docker-initunlocklnd.sh |
Adds resumable password migration and restart handling. |
docker-entrypoint.sh |
Detects pending migrations and resets macaroon data. |
tests/docker-password-migration.sh |
Tests legacy passwords, interruption recovery, and rotation. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+16
to
+17
| if [[ "${LND_DAEMON_PID:-}" =~ ^[0-9]+$ && "$LND_DAEMON_PID" == "$PPID" ]]; then | ||
| kill -TERM "$LND_DAEMON_PID" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves Docker startup handling and adds regression coverage.