Repository navigation
Update Docker startup - #16
Closed
r2ckstardev wants to merge 2 commits into
Closed
r2ckstardev wants to merge 2 commits into
r2ckstardev wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The security-sensitive state migration and destructive authentication rotation require final human validation with the Docker integration test.
Pull request overview
Improves Docker startup safety for wallet password migration and macaroon rotation.
Changes:
- Adds atomic, permission-restricted password-state persistence and retry handling.
- Coordinates password migration with macaroon root-key rotation.
- Adds Docker regression scenarios for migrations, interruptions, and recovery.
File summaries
| File | Description |
|---|---|
docker-initunlocklnd.sh |
Adds durable migration and recovery logic. |
docker-entrypoint.sh |
Coordinates startup-time macaroon rotation. |
tests/docker-password-migration.sh |
Exercises migration and restart scenarios. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rockstardev
marked this pull request as draft
September 14, 2026 22:30
Member
|
Superseeded by #17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves Docker startup handling and adds regression coverage.