btcutil: Add library functions for BIP-0352 silent payment _send_ support #2244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
force-pushed
the
silent-payments
branch
from
95b791d to
f8bf376
Compare
Pull Request Test Coverage Report for Build 18942746453Details
💛 - Coveralls |
guggero
force-pushed
the
silent-payments
branch
4 times, most recently
from
2a9a931 to
996c4d3
Compare
guggero
force-pushed
the
silent-payments
branch
from
996c4d3 to
28b7587
Compare
guggero
force-pushed
the
silent-payments
branch
2 times, most recently
from
88fa441 to
8a4fe70
Compare
Contributor
|
This is great work and very welcome. However, BIP-375 specifies exclusion for PSBTv0, so this will not be compatible with other PSBT libraries/wallets. Imho it would be best to focus on adding support for PSBTv2 first (#2328). |
guggero
force-pushed
the
silent-payments
branch
from
8a4fe70 to
dc6f721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds library/API functionality for Silent Payment send support.
Implements the following BIPs (or pull requests to BIPs):
Goal is to address send support first as that's rather straightforward. Receive support is much more involved as it requires scanning the chain in a specific manner.