Minor refactor to improve code health #2389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit provides a minor fix on the format.
A minor refactor on method `OnGetData`.
Pull Request Test Coverage Report for Build 15872035018Details
💛 - Coveralls |
ellemouton
reviewed
Jun 24, 2025
server.go
Outdated
| sp.server.syncManager.QueueHeaders(msg, sp.Peer) | ||
| } | ||
|
|
||
| // handleGetData is invoked when a peer receives a getdata bitcoin message and |
Contributor
There was a problem hiding this comment.
nit in commit message: s/prune/prone
|
|
||
| // handleGetData is invoked when a peer receives a getdata bitcoin message and | ||
| // is used to deliver block and transaction information. | ||
| func (sp *serverPeer) OnGetData(_ *peer.Peer, msg *wire.MsgGetData) { |
Contributor
There was a problem hiding this comment.
pre-existing but the method name is incorrect
Collaborator
Author
There was a problem hiding this comment.
cool now fixed
7 tasks
GustavoStingelin
suggested changes
Jun 24, 2025
The preivous usage of two channels - by piping them together to create a semaphore effect, is difficult to follow and prone to bugs. This commit now refactors the method to explicitly implement a semaphore. Prior to this change, we would allow at max 3 concurrent goroutines - this is now bumped to 5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some refactoring to methods like
OnGetDataandBtcEncode, aiming to improve readability and code health.