Automating CLI versioning#1163
Open
sergey3bv wants to merge 1 commit into
Open
Conversation
Author
|
Hey, @Roasbeef, @yyforyongyu, @guggero, could you please take a look at the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Addressing #790. Added runtime/debug package for automatic versioning. It uses the last git tag to get the current version. Variable
appVersioncan be used to set the version manually.I'm not really happy with panic so let me please know what it can be replaced with.
Steps to Test
-ldflags "-X github.com/btcsuite/btcwallet/build.appVersion=<custom_version>"Pull Request Checklist
Testing
Code Style and Documentation
📝 Please see our Contribution Guidelines for further guidance.