Skip to content

Resolve "Websocket reconnect should be mentioned in the logged warning"#388

Merged
btschwertfeger merged 6 commits intomasterfrom
387-websocket-reconnect-should-be-mentioned-in-the-logged-warning
Aug 3, 2025
Merged

Resolve "Websocket reconnect should be mentioned in the logged warning"#388
btschwertfeger merged 6 commits intomasterfrom
387-websocket-reconnect-should-be-mentioned-in-the-logged-warning

Conversation

@btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Aug 3, 2025

  • Updating the logged message to notify the users about future recovery of a closed connection.
  • "Kraken Cryptocurrency Exchange" -> "Kraken Crypto Asset Exchange"

Closes #387

@codecov
Copy link

codecov bot commented Aug 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.46%. Comparing base (bfd65d5) to head (f9912d4).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   87.48%   87.46%   -0.03%     
==========================================
  Files          22       22              
  Lines        1974     1970       -4     
==========================================
- Hits         1727     1723       -4     
  Misses        247      247              
Flag Coverage Δ
unittests 87.46% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/kraken/futures/websocket/__init__.py 84.44% <100.00%> (-0.18%) ⬇️
src/kraken/spot/websocket/connectors.py 87.00% <100.00%> (-0.15%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@btschwertfeger btschwertfeger merged commit 3926dd7 into master Aug 3, 2025
40 checks passed
@btschwertfeger btschwertfeger deleted the 387-websocket-reconnect-should-be-mentioned-in-the-logged-warning branch August 3, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Websocket reconnect should be mentioned in the logged warning

1 participant