Resolve "Stock trade compatibility"#399
Merged
btschwertfeger merged 7 commits intomasterfrom Sep 20, 2025
Merged
Conversation
btschwertfeger
added
the
Documentation
…used GitHub Action runners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #399 +/- ##
==========================================
+ Coverage 83.56% 87.34% +3.77%
==========================================
Files 22 22
Lines 1959 1959
==========================================
+ Hits 1637 1711 +74
+ Misses 322 248 -74
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive support for xStocks (tokenized stocks) trading to the Kraken SDK, including documentation, tests, and examples. The PR also modernizes the documentation theme and structure.
- Adds xStocks trading functionality with proper test coverage and configuration
- Updates documentation to use modern Furo theme with improved styling
- Provides comprehensive examples and documentation for xStocks usage
Reviewed Changes
Copilot reviewed 22 out of 37 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/spot/test_xstocks_basic.py | New test suite for xStocks functionality with market and trade client tests |
| tests/spot/conftest.py | Added xStocks-specific test fixtures and configuration |
| tests/futures/test_futures_trade.py | Refactored TEST_ORDER_IDS from instance to class variable |
| src/kraken/base_api/init.py | Updated SpotClient docstring to mention xStocks support |
| pyproject.toml | Added xstocks pytest marker |
| examples/xstocks_examples.py | New comprehensive examples for xStocks trading |
| doc/* | Multiple documentation updates for theme change and restructuring |
| README.md | Updated to highlight xStocks support and provide usage examples |
| .github/workflows/* | Added xStocks credentials to CI/CD workflows |
| Makefile | Updated test coverage reporting options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds documentation, tests, and examples on how to use the SDK for trading xStocks on Kraken.
Other changes:
Closes #393