Fix premature SSE event split on embedded line endings #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug btubbs#28 by changing how lines are parsed. Previously if a double line ending was embedded in the vent it could trip up SSEClient and return early, resulting in an unteriminated string/ValueError.
Expanded the test to include tests to cover CR, LF, CRLF instead of just LF (newline) and renamed the test to be more descriptive as to its purpose.
Collaborator
Author
|
This has been in continuous testing since last night but going to run it on the Wikimedia feed for a couple of days just to make sure that everything is working as desired, especially considering the relative rarity/randomness of the offending event message firing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug #28 by changing how lines are parsed. Previously if a double line ending was embedded in the event it could trip up SSEClient and return early, resulting in an unterminated string/ValueError. This also helps to resolve a vulnerability identified by @decatur in this comment by eliminating a regular expression application on all buffered data for each chunk.