Add install guiding and add config file support for custom buck2 binary path #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `ensure_buck2_installed` function to verify Buck2 installation across multiple commands. - Enhanced user prompts with colored output for better visibility and user experience. - Updated `Cargo.toml` and `Cargo.lock` to include the `colored` dependency for terminal output styling.
- Added a selection prompt for users to choose between automatic installation and manual guidance. - Updated `Cargo.toml` to include the `inquire` dependency for interactive prompts.
- Integrated configuration loading from `~/.config/buckal/config.toml` - Added `toml` dependency to `Cargo.toml` for configuration file parsing.
There was a problem hiding this comment.
Pull Request Overview
This PR adds Buck2 installation guidance and configuration support for custom Buck2 binary paths. It introduces an interactive installation flow that prompts users when Buck2 is not available and adds configuration file support for specifying custom Buck2 binary locations.
Key changes:
- Interactive Buck2 installation flow with automatic and manual options
- Configuration system for custom Buck2 binary paths via
~/.config/buckal/config.toml - Centralized Buck2 command execution through a new
Buck2Commandabstraction
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils.rs | Adds Buck2 installation checking, prompting, and automatic installation functions |
| src/buck2.rs | New Buck2 command abstraction that supports custom binary paths from config |
| src/config.rs | Configuration system for loading custom Buck2 binary paths |
| src/commands/*.rs | Updated all command files to use Buck2Command and ensure Buck2 is installed |
| src/main.rs | Added new module declarations for buck2 and config |
| README.md | Added configuration documentation |
| Cargo.toml | Added dependencies for colored output, user prompts, and TOML parsing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| /// Get the configuration file path | ||
| pub fn config_path() -> PathBuf { | ||
| let home = std::env::var("HOME").unwrap_or_else(|_| ".".to_string()); |
There was a problem hiding this comment.
Using the HOME environment variable is Unix-specific and will not work on Windows. Consider using dirs::config_dir() or std::env::var('USERPROFILE') for cross-platform compatibility.
genedna
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add install guiding if buck2 is not available.
It will show installing options for user
Also this pr add config file support for custom buck2 binary path. It is useful for us, since our buck2 is little different