feat(ui/dashboard): flags discard change #2119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveninhle
changed the title
steveninhle
force-pushed
the
feat-flags-discard-change
branch
2 times, most recently
from
fb1ad41 to
8cf02cd
Compare
steveninhle
requested review from
cre8ivejp,
hvn2k1,
kakcy and
nnnkkk7
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR implements a comprehensive "discard changes" feature for the feature flag details targeting system. It adds functionality to track and revert unsaved changes in different sections of the targeting configuration.
- Adds a discard changes modal with support for multiple change types (prerequisites, individual rules, custom rules, default rules)
- Implements change tracking and comparison utilities for detecting modifications in targeting configurations
- Adds undo buttons throughout the targeting interface to trigger discard operations
Reviewed Changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
ui/dashboard/src/utils/style.ts |
Adds capitalize utility function for string formatting |
ui/dashboard/src/utils/data-type.ts |
Updates isEmpty function to support generic array types |
ui/dashboard/src/pages/feature-flag-details/targeting/utils.ts |
Adds extensive discard changes logic and utility functions |
ui/dashboard/src/pages/feature-flag-details/targeting/types.ts |
Defines types for discard changes functionality |
ui/dashboard/src/pages/feature-flag-details/targeting/segment-rule/rule.tsx |
Adds null safety for feature rules and clauses |
ui/dashboard/src/pages/feature-flag-details/targeting/segment-rule/index.tsx |
Replaces remove button with undo button for discard changes |
ui/dashboard/src/pages/feature-flag-details/targeting/prerequisite-rule/index.tsx |
Adds undo button for prerequisite rule discard changes |
ui/dashboard/src/pages/feature-flag-details/targeting/prerequisite-rule/condition.tsx |
Adds validation and auto-selection for prerequisite variations |
ui/dashboard/src/pages/feature-flag-details/targeting/individual-rule/index.tsx |
Adds undo button for individual rule discard changes |
ui/dashboard/src/pages/feature-flag-details/targeting/index.tsx |
Integrates discard changes functionality into main targeting component |
ui/dashboard/src/pages/feature-flag-details/targeting/default-rule/index.tsx |
Adds undo button for default rule discard changes |
ui/dashboard/src/pages/feature-flag-details/elements/discard-changes-modal/index.tsx |
Implements the discard changes modal component |
ui/dashboard/src/components/date-time-picker/custom-datepicker.css |
Fixes z-index for datepicker triangle |
ui/dashboard/src/@types/feature.ts |
Adds type field to FeatureRuleClause |
ui/dashboard/src/@locales/ja/form.json |
Adds Japanese translations for discard changes |
ui/dashboard/src/@locales/ja/common.json |
Adds Japanese translations for common discard actions |
ui/dashboard/src/@locales/en/form.json |
Adds English translations for discard changes |
ui/dashboard/src/@locales/en/common.json |
Adds English translations for common discard actions |
ui/dashboard/src/@icons/index.tsx |
Exports new warning and arrow icons |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
4
to
5
| import { capitalize } from 'lodash'; | ||
| import { cn } from 'utils/style'; |
There was a problem hiding this comment.
This import uses lodash's capitalize function, but the project has a custom capitalize function in utils/style.ts. The imports should be consistent - either use the custom function or ensure the lodash version is intended.
Suggested change
| import { capitalize } from 'lodash'; | |
| import { cn } from 'utils/style'; | |
| import { capitalize, cn } from 'utils/style'; |
Copilot uses AI. Check for mistakes.
| "custom-rule-audience-not-include-desc": "<p>この配分に含まれていない <b>{{percent}}%</b> には <b>{{variation}}</b> が提供されます</p>", | ||
| "custom-rule-audience-include-desc": "<p>この配分に含まれている <b>{{percent}}%</b> には提供されます</p>", | ||
| "custom-rule-default-strategy-discard-desc": "デフォルトルールに設定", | ||
| "custom-rule-default-audience-discard-desc": "デフォルトオーディエンスに設定します" |
There was a problem hiding this comment.
Missing trailing comma after the translation value. This should end with a comma to maintain consistent JSON formatting.
Copilot uses AI. Check for mistakes.
steveninhle
force-pushed
the
feat-flags-discard-change
branch
from
7985caa to
b461ec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.