Reduce diff for protovalidate/quickstart-es buf.gen.yaml #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In protovalidate/quickstart-es, start/buf.gen.yaml and finish/buf.gen.yaml differ quite a bit:
This changes the diff to:
version: v2 clean: true inputs: - directory: proto plugins: - remote: buf.build/bufbuild/es:v2.5.1 out: src/gen opt: - target=ts - import_extension=js + include_imports: trueAdding
include_importsis almost always necessary to add with protovalidate and protobuf-es (so that the imported filebuf/validate/validate_pb.tsis generated).I don't believe it makes sense to switch from JavaScript to TypeScript to show how to use protovalidate, so I think we should generate ts right from the start. Similar for
clean: true.