Update Iceberg quickstart to automatically configure its topic #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodaine
approved these changes
May 21, 2025
bufdev
requested changes
May 22, 2025
| doMain(false, action) | ||
| } | ||
|
|
||
| // MainAutoCreateTopic is used by the producer's main function. It is just like [Main] except |
There was a problem hiding this comment.
This is not the way to do this: app.Main is a top-level entry point that should do minimal setup work that is universal for all binaries. Instead, you've added a new MainAutoCreateTopic that does application logic. All application logic specific to the binary should be done within the do function that main invokes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be merged at the same time as a corresponding PR in
docs.Goal: Users walking through the Iceberg quickstart shouldn't have to edit any configurations. All they should need to do is copy/paste/run terminal commands and then Spark queries.
Changes in this PR:
topic-configparameters by updatingapp.goandkafka.gobufstream-demo. They do contain some unused code, but I don't want to create one-off, "special" versions for examples.bufstream.yamlwith the local REST catalog. Docs are updated to suggest people open the file to see it, but they don't need to make any changes.