Add Docker Compose Quickstart #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a reference for bufstream users.
bufdev
requested changes
May 27, 2025
There was a problem hiding this comment.
This needs some love for public consumption - the judgment of this project is based on the UX from a user hitting buf.build/docs, to finding this, and what their expected comprehension is. We need some work on this to make sure that users understand what is going on at every step. cc @jrinehart-buf
bufdev
reviewed
May 27, 2025
rubensf
commented
Jun 2, 2025
| healthcheck: | ||
| test: ["CMD", "curl", "--silent", "--fail", "--output", "/dev/null", "http://localhost:9000/minio/health/live"] | ||
| interval: 2s | ||
| retries: 30 |
There was a problem hiding this comment.
Using the defaults for interval and retries for these too leads to a 10-20 seconds until docker will take these as ready, so while it increases the LOC we believe it provides a substantially more pleasant user experience.
bufdev
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a reference for bufstream users.