Skip to content

Remove unused options for excluded types #3758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

emcfarlane
Copy link
Contributor

@emcfarlane emcfarlane commented Apr 8, 2025

This is an optimization to remove unused options from the filtered file descriptor. These options aren't required in the image, the extension is excluded. We remove them to reduce the size of generated code.

Fixes #3730

@emcfarlane emcfarlane requested a review from doriable April 8, 2025 18:37
Copy link
Contributor

github-actions bot commented Apr 8, 2025

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 8, 2025, 6:37 PM

@bhollis
Copy link

bhollis commented Apr 11, 2025

Excited about this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused options on field descriptors with excluded types
2 participants