Skip to content

Fix config migration for removed rules #3810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix config migration for removed rules #3810

wants to merge 4 commits into from

Conversation

emcfarlane
Copy link
Contributor

@emcfarlane emcfarlane commented May 2, 2025 •
edited
Loading

This PR fixes unknown rules after a config migration by filtering any used IDs by the target v2 rule and categories ID set.

@emcfarlane emcfarlane requested a review from doriable May 2, 2025 18:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMay 7, 2025, 10:12 PM

@emcfarlane emcfarlane marked this pull request as ready for review May 7, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doriable doriable Awaiting requested review from doriable

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emcfarlane