Add ppc64le architecture to release script #3811
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
doriable
reviewed
May 2, 2025
Comment on lines
+111
to
+117
| elif [ "${arch}" == "ppc64le" ]; then | ||
| if [ "${os}" == "Linux" ]; then | ||
| CGO_ENABLED=0 GOOS=$(goos "${os}") GOARCH=$(goarch "${arch}") \ | ||
| go build -a -ldflags "-s -w" -trimpath -buildvcs=false -o "${dir}/bin/${binary}${extension}" "${DIR}/cmd/${binary}" | ||
| else | ||
| continue | ||
| fi |
There was a problem hiding this comment.
Since we would not need to provide an additional env var for the ppc64le build (e.g. GOARM for the arm7 binary), we could something similar to what you've done below in the else clause (and would not need to add a repeated build statement here):
else
if [ "${arch}" == "ppc64le" ] && [ "${os}" != "Linux" ]; then
continue
fi
CGO_ENABLED=0 GOOS=$(goos "${os}") GOARCH=$(goarch "${arch}") \
go build -a -ldflags "-s -w" -trimpath -buildvcs=false -o "${dir}/bin/${binary}${extension}" "${DIR}/cmd/${binary}"
fi
|
This has been superseded by #3840 which adds a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ppc64le architecture to releases. This is necessary for the rules_buf bazel module to work properly on the ppc64le architecture as a binary release is required by the rules_buf_toolchains target.