Skip to content

Add ppc64le architecture to release script #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jenkins-J
Copy link

Add ppc64le architecture to releases. This is necessary for the rules_buf bazel module to work properly on the ppc64le architecture as a binary release is required by the rules_buf_toolchains target.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment on lines +111 to +117
elif [ "${arch}" == "ppc64le" ]; then
if [ "${os}" == "Linux" ]; then
CGO_ENABLED=0 GOOS=$(goos "${os}") GOARCH=$(goarch "${arch}") \
go build -a -ldflags "-s -w" -trimpath -buildvcs=false -o "${dir}/bin/${binary}${extension}" "${DIR}/cmd/${binary}"
else
continue
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we would not need to provide an additional env var for the ppc64le build (e.g. GOARM for the arm7 binary), we could something similar to what you've done below in the else clause (and would not need to add a repeated build statement here):

      else
        if [ "${arch}" == "ppc64le" ] && [ "${os}" != "Linux" ]; then
          continue
        fi
        CGO_ENABLED=0 GOOS=$(goos "${os}") GOARCH=$(goarch "${arch}") \
          go build -a -ldflags "-s -w" -trimpath -buildvcs=false -o "${dir}/bin/${binary}${extension}" "${DIR}/cmd/${binary}"
      fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants