Validate features.utf8_validation and features.message_encoding#596
Merged
Conversation
emcfarlane
reviewed
Oct 9, 2025
emcfarlane
reviewed
Oct 10, 2025
| } | ||
| ======= | ||
| } | ||
| >>>>>>> mcy/editions-validation |
emcfarlane
approved these changes
Oct 14, 2025
emcfarlane
reviewed
Oct 14, 2025
| prev := 0 | ||
| for _, edit := range edits { | ||
| buf.WriteString(original[prev : edit.Start-start]) | ||
| buf.WriteString(original[prev:max(prev, edit.Start-start)]) |
Member
Author
There was a problem hiding this comment.
This happens if there are suggestion spans that overlap each other. This only happens in some pathological cases, but it was causing crashes while rendering.
mcy
added a commit
that referenced
this pull request
Oct 16, 2025
…596) This validates that: - `features.utf8_validation` is only used on string fields. - `features.message_encoding` is only used on length-prefixed message fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This validates that:
features.utf8_validationis only used on string fields.features.message_encodingis only used on length-prefixed message fields.