Skip to content

Validate the json_name pseudo-option#606

Merged
mcy merged 8 commits into
mainfrom
mcy/json-name
Oct 17, 2025
Merged

Validate the json_name pseudo-option#606
mcy merged 8 commits into
mainfrom
mcy/json-name

Conversation

@mcy

@mcy mcy commented Oct 15, 2025

Copy link
Copy Markdown
Member

This PR adds validation for JSON name conflicts. It includes:

  • New infrastructure for accurately converting names between different casings.
  • A new Member.PseudoOptions method for getting a member's pseudo-options.
  • Validation of the JSON names themselves, including detailed diagnostics.
  • Outputing the pseudo-option to FDP, which protoc does unconditionally (!) for non-extension fields.

@mcy
mcy requested a review from emcfarlane October 15, 2025 22:15
@mcy
mcy merged commit f8d5684 into main Oct 17, 2025
6 checks passed
@mcy
mcy deleted the mcy/json-name branch October 17, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants