Add policy and policy rule endpoints #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo5h
approved these changes
Apr 29, 2025
mo5h
left a comment
mo5h
left a comment
There was a problem hiding this comment.
Code review only, but changes look reasonable
My only nitpick would be that it'd be preferable if we made the changes to make it backwards compatible with earlier faraday versions in a separate PR from the change to add the policy APIs
Author
|
fair point, the revert was in this PR #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following endpoints:
List Policies
Add Policy
Get Policy
Update Policy
Delete Policy
List Policy Rules
Add Policy Rule
Get Policy Rule
Update Policy Rule
Delete Policy Rule