update go net version and go verion #1268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
dosubot
bot
added
size:L
eamora-ab
commented
Mar 25, 2025
| @@ -30,7 +31,7 @@ func newVXLANHandler(port int, vnis []int) (*vxlanHandle, error) { | |||
| vxlanHandle := &vxlanHandle{} | |||
| con, err := net.ListenUDP("udp", &addr) | |||
| if err != nil { | |||
| return nil, fmt.Errorf(err.Error()) | |||
| return nil, fmt.Errorf("failed to create VXLANHandler: %w", err) | |||
There was a problem hiding this comment.
Something needed to change here cause Go 1.24 causes an error when we use fmt.Errorf without args. That said I could have easily instead just done return nil, err or return nil, fmt.Error(err.Error()) of something like that if we preferred.
eamora-ab
commented
Mar 25, 2025
There was a problem hiding this comment.
So I removed the entire jekyll site since a) it was flagged with vulns from old ruby gem versions and b) it appeared unused.
|
Its fair, reduce vurneability surface |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.