-
Notifications
You must be signed in to change notification settings - Fork 11
Update the fastlane plugin to use the BugSnag CLI #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
775ef33 to
0083788
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We refer to this in our legacy docs along with the Homebrew install.
I don't think we should keep it, but we should think about updates to:
- the readme
- the legacy docs
- Homebrew
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How many of these tests do we no longer run? Is there good reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests were all related to the bin/bugsnag-dsym-upload file, which has now been integrated into the BugSnag CLI, which has tests to cover its functionality.
tools/fastlane-plugin/lib/fastlane/plugin/bugsnag/actions/upload_symbols_to_bugsnag.rb
Show resolved
Hide resolved
tools/fastlane-plugin/lib/fastlane/plugin/bugsnag/actions/upload_symbols_to_bugsnag.rb
Outdated
Show resolved
Hide resolved
tools/fastlane-plugin/lib/fastlane/plugin/bugsnag/actions/upload_symbols_to_bugsnag.rb
Show resolved
Hide resolved
8ce362f to
c241690
Compare
Goal
Update the Fastlane plugin to delegate dSYM uploads to the BugSnag CLI, improving consistency and maintainability.
Changeset
Testing