Use shared tracker in network breadcrumbs package #2645
+57
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the network-breadcrumbs plugin to use a shared request tracker implementation instead of maintaining its own monkey-patching logic. The change promotes code reuse and centralizes request tracking functionality.
Key Changes:
- Replaces inline XMLHttpRequest and fetch monkey-patching with the shared
@bugsnag/request-trackerpackage - Adds auto-loading capability for the request tracker plugin if not already present
- Simplifies the network-breadcrumbs plugin implementation by delegating request tracking to the shared tracker
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/generate-react-native-fixture.js | Adds @bugsnag/request-tracker to internal dependencies for React Native fixture generation |
| packages/request-tracker/package.json | Includes lib/ directory in published package files |
| packages/plugin-network-breadcrumbs/package.json | Adds @bugsnag/request-tracker as a runtime dependency |
| packages/plugin-network-breadcrumbs/network-breadcrumbs.js | Replaces custom monkey-patching logic with shared tracker integration, including auto-loading and fallback handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Implement shared tracker in the network-breadcrumbs plugin
Testing
Covered by existing tests