Modify validation framework for custom use #671
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cawllec
changed the title
|
Closed in favour of #672 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Aims to rework our existing validation setup, which currently only includes trace validation, to be extendable through configuration options, allowing us to impose custom validation rules in each test environment as required.
Changes
This PR primarily refactors the trace validation class to be more generic, building from a
ValidatorBaseclass with the generic methods attached. This base class will be used as a jumping off point for any future validators.Tests
The unit tests have been updated, and existing tests for the trace validation logic remains in place.