Stop using BitBar deviceGroupId capability #797
Merged
+8
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twometresteve
changed the title
twometresteve
changed the title
joshedney
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Stop using the
deviceGroupIdcapability as it no longer consistently provides an available device.Design
I've simply removed the
if device_group_ids.size > 1guard and what was itselsebranch, meaning that we will always query the API for an available device within that group. Although we might lose a race with another Maze Runner istance, we have retry logic for that and overall it will be more reliable and within our control.Tests
A Buildkite job that needed ANDROID_8 failed to get an available device with.the previous version of MR (using the capability). Seconds later I ran this branch locally and it obtained a device on the first attempt.