Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): add custom log format for foreground nodes #8796

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

adrianbenavides
Copy link
Member

@adrianbenavides adrianbenavides commented Feb 12, 2025

  • Fix session loop updates the initial_connect_was_called var after reconnecting
  • Add custom log format used in node create --foreground that will print log messages with the target ockam_command:user in the terminal as regular output
  • Add info logs in the portal worker connect/disconnect events
portal-events.mp4

Copy link
Member

@etorreborre etorreborre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a good idea to not require a CliState to instantiate a Notifier but I would not make it a singleton, for the usual mocking and testing reasons:

  • It's not easy to replace with a Notifier with a different behaviour
  • Any tests making some assertions on the Notifier cannot be executed concurrently and has to be carefully isolated.

I know that it is a currently a bit painful to pass components around because we don't have any DI support but I would still build that component and pass it around manually, first on the CliState, then the NodeManager, the SessionReplacer etc...

@adrianbenavides adrianbenavides changed the title refactor(rust): decouple ui notifications from clistate feat(rust): add custom log format for foreground nodes Feb 18, 2025
@adrianbenavides adrianbenavides force-pushed the adrian/fix-session-reconnect-messages branch 4 times, most recently from e004607 to 19d458b Compare February 19, 2025 18:09
@adrianbenavides adrianbenavides force-pushed the adrian/fix-session-reconnect-messages branch 4 times, most recently from 4e8b561 to 8be056e Compare February 20, 2025 08:28
@adrianbenavides adrianbenavides force-pushed the adrian/fix-session-reconnect-messages branch from 8be056e to 8f3f6d6 Compare February 23, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants