Make test-deployment-bare run on Windows#178
Conversation
|
Just a draft for now as I'd like to see how it gets on with the CI here! |
a1508a3 to
c6cc196
Compare
c6cc196 to
a529b11
Compare
|
I think this is now ready. I got caught out by the github actions windows environment. To cut a long story short, it turns out that sending an interrupt on Windows (which is CTRL_C_EVENT under the hood) requires a console environment. I tried many different ways of creating a console but in the end the only way I found of creating a console environment that was good enough to send a ctrl+c was to use Graceful termination on Windows is a bit of a disaster zone. |
|
Something is not working properly. The Buildbarn deployments exits early and the Bazel build reports exit code 34, but still the Github Workflow succeeds. |
a529b11 to
5a916ae
Compare
|
Thanks for spotting that. I think there's two issues:
|
|
The exit code propagation now works correctly (I added a exit 1 at the end of the script on a branch just to test): https://github.com/tomgr/bb-deployments/actions/runs/17308199155/job/49136347413?pr=3 |
This uses the WinFSP-based VFS implementation.
5a916ae to
8822c72
Compare
|
@tomgr Thank you very much for your excellent work and this contribution! |
|
Hooray! |
This uses the WinFSP-based VFS implementation.