Refactor theme selection system - #352
Open
isakstenstrom wants to merge 1 commit into
Open
Conversation
isakstenstrom
force-pushed
the
refactor-theme-system
branch
2 times, most recently
from
September 2, 2026 07:41
e5ca050 to
c31ac57
Compare
isakstenstrom
force-pushed
the
refactor-theme-system
branch
from
September 2, 2026 07:43
c31ac57 to
918ce15
Compare
isakstenstrom
force-pushed
the
refactor-theme-system
branch
from
September 2, 2026 07:44
918ce15 to
8fe283c
Compare
The current implementation of light/dark theming is achieved using an inconsistent mix of CSS and Ant Design options. This commit unifies the system into a single ConfigProvider residing in a ThemeContext, which is responsible for storing and setting theme choices. It also adds the ability to choose a "System" theme, which automatically selects the appropriate theme based on the prefers-color-scheme media query; this solves the issue where after selecting a theme, it was stored in localStorage and the user had no in-UI solution for returning to a browser-determined theme. Third, it performs some refactors to the App Bar, to ensure more consistency with Ant Design development patterns and more properly support the new theme system.
isakstenstrom
force-pushed
the
refactor-theme-system
branch
from
September 2, 2026 07:45
8fe283c to
b63e495
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of light/dark theming is achieved using an inconsistent mix of CSS and Ant Design options. This commit unifies the system into a single ConfigProvider residing in a ThemeContext, which is responsible for storing and setting theme choices. It also adds the ability to choose a "System" theme, which automatically selects the appropriate theme based on the prefers-color-scheme media query; this solves the issue where after selecting a theme, it was stored in localStorage and the user had no in-UI solution for returning to a browser-determined theme. Third, it performs some refactors to the App Bar, to ensure more consistency with Ant Design development patterns and more properly support the new theme system.