Skip to content

address performance issues with /tests and /targets views#63

Merged
trey-ivy merged 5 commits intomainfrom
bugfix/targetsView
Jan 24, 2025
Merged

address performance issues with /tests and /targets views#63
trey-ivy merged 5 commits intomainfrom
bugfix/targetsView

Conversation

@trey-ivy
Copy link
Collaborator

@trey-ivy trey-ivy commented Jan 21, 2025

when running in an environment where target entries scale and become very large, the pass rate functionality can cause the targets and tests views to become slow and unresponsive. to address this issue, i'm removing pagination, avg/min/max duration and pass rate from these views and adjusting the backend queries respectively to see if this improves performance enough to make the application more responsive. I'm also adjusting the cache policy from cache and network to the default and adding a long poll interval and indexing the label fields of target pair and test collection in the db. In a subsequent PR, I will add avg/min/max/passrate/# runs to the test details view.

additionally, adding the pprof endpoints to help performance tuning in the future

@trey-ivy
Copy link
Collaborator Author

the new views look different, but i don't think we're losing that much functionality. idk how useful it was to have avg/min/max/passrate/#runs on the list view. The idea was to implement sorting at some point to allow you to find things like your longest running jobs and most built targets/etc. I'm still going to provide this data but it won't be pulled real time. it will be calculated daily and moved to the trends view. You can of course still write a custom query to pull the data from the graphql api, but the performance hit was causing views to break and become unresponsive.

image

@trey-ivy trey-ivy changed the title address performance issues w/passrate address performance issues with /tests and /targets views Jan 24, 2025
@trey-ivy trey-ivy self-assigned this Jan 24, 2025
@trey-ivy trey-ivy linked an issue Jan 24, 2025 that may be closed by this pull request
@trey-ivy trey-ivy requested a review from mortenmj January 24, 2025 15:21
@trey-ivy trey-ivy merged commit 0afbd81 into main Jan 24, 2025
2 checks passed
@isakstenstrom isakstenstrom deleted the bugfix/targetsView branch January 26, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

performance issues on targets/tests views

1 participant

Comments