fix: actionCache miss reason does NOT have an "UNKNOWN" enum at index 0#79
Merged
trey-ivy merged 3 commits intobuildbarn:mainfrom Feb 11, 2025
Merged
Conversation
trey-ivy
requested changes
Feb 10, 2025
Collaborator
There was a problem hiding this comment.
Thanks for putting this up! I have some minor feedback, but this is a great catch!
Also i think there is one more place you need to update. frontend/src/components/ActionCacheMetrics/index.module.css should include the color for unconditional execution.
Collaborator
|
hey @jasonschroeder-sfdc |
And also added "UNCONDITIONAL_EXECUTION" enum consistently (Green for the UI)
jasonschroeder-sfdc
force-pushed
the
action-cache-enums
branch
from
e885156 to
553fc74
Compare
Contributor
Author
|
All set, @trey-ivy ! I just picked green for |
Contributor
Author
|
Let me know if you'd like me to squash commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MissReasonenum doesn't align with the missReason() label.I also added "UNCONDITIONAL_EXECUTION" enum consistently (Green for the UI)