Fix validation of new bazel http header qualifiers#55
Merged
tomcoldrick-ct merged 1 commit intobuildbarn:masterfrom Feb 20, 2025
Merged
Fix validation of new bazel http header qualifiers#55tomcoldrick-ct merged 1 commit intobuildbarn:masterfrom
tomcoldrick-ct merged 1 commit intobuildbarn:masterfrom
Conversation
Collaborator
tomcoldrick-ct
left a comment
tomcoldrick-ct
left a comment
There was a problem hiding this comment.
Looks good, I think you've included an unrelated change to the function below though.
tomgr
force-pushed
the
bugfix/http-header-validation
branch
from
128975f to
af04301
Compare
tomgr
force-pushed
the
bugfix/http-header-validation
branch
from
af04301 to
dc38564
Compare
tomcoldrick-ct
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for this was added in #49 but it seems the validation code wasn't updated. I ran into this whilst using rules_oci, which sets various headers, leading to errors like: