Skip to content

chore: bump bb-storage to dc342e1 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EdSchouten merged 4 commits into from
Mar 23, 2026
Merged

chore: bump bb-storage to dc342e1 #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95787e8
chore: bump bb-storage to dc342e1
sharmila-oai Mar 18, 2026
3c0a4b3
Run bazel run @com_github_buildbarn_bb_storage//tools:reformat
sharmila-oai Mar 19, 2026
22bc443
Add configurable zstd pool
sharmila-oai Mar 20, 2026
6bb9d36
Run formatting
sharmila-oai Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ git_override(

git_override(
module_name = "com_github_buildbarn_bb_storage",
commit = "6002cad335378bbdcdda4225d47c7dc2c08a6d94",
commit = "dc342e1799d72bd927ffc0af1f429e7044118b07",
patches = [
"//:patches/com_buildbarn_bb_storage/workflows.diff",
],
Expand Down
1 change: 1 addition & 0 deletions cmd/bb_remote_asset/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ go_library(
"@com_github_buildbarn_bb_storage//pkg/grpc",
"@com_github_buildbarn_bb_storage//pkg/program",
"@com_github_buildbarn_bb_storage//pkg/util",
"@com_github_buildbarn_bb_storage//pkg/zstd",
"@org_golang_google_genproto_googleapis_rpc//status",
"@org_golang_google_grpc//:grpc",
"@org_golang_google_grpc//codes",
Expand Down
4 changes: 4 additions & 0 deletions cmd/bb_remote_asset/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
bb_grpc "github.com/buildbarn/bb-storage/pkg/grpc"
"github.com/buildbarn/bb-storage/pkg/program"
"github.com/buildbarn/bb-storage/pkg/util"
bb_zstd "github.com/buildbarn/bb-storage/pkg/zstd"
protostatus "google.golang.org/genproto/googleapis/rpc/status"

"google.golang.org/grpc"
Expand Down Expand Up @@ -58,13 +59,16 @@ func main() {
return util.StatusWrap(err, "Failed to create Push Authorizer from Configuration")
}

zstdPool := bb_zstd.NewPoolFromConfiguration(config.ZstdPool)

// Initialize CAS storage access
contentAddressableStorageInfo, err := blobstore_configuration.NewBlobAccessFromConfiguration(
dependenciesGroup,
config.ContentAddressableStorage,
blobstore_configuration.NewCASBlobAccessCreator(
grpcClientFactory,
int(config.MaximumMessageSizeBytes),
zstdPool,
),
)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ replace go.uber.org/mock => go.uber.org/mock v0.4.0
require (
github.com/bazelbuild/buildtools v0.0.0-20260211083412-859bfffeef82
github.com/bazelbuild/remote-apis v0.0.0-20260216160025-715b73f3f9e4
github.com/buildbarn/bb-storage v0.0.0-20260303071613-6002cad33537
github.com/buildbarn/bb-storage v0.0.0-20260317135248-dc342e1799d7
github.com/golang/mock v1.7.0-rc.1
github.com/prometheus/client_golang v1.23.2
github.com/stretchr/testify v1.11.1
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ github.com/bazelbuild/remote-apis v0.0.0-20260216160025-715b73f3f9e4/go.mod h1:7
github.com/benbjohnson/clock v1.1.0/go.mod h1:J11/hYXuz8f4ySSvYwY0FKfm+ezbsZBKZxNJlLklBHA=
github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
github.com/buildbarn/bb-storage v0.0.0-20260303071613-6002cad33537 h1:81k5KiFlYyaQaheb5pe9p/nz4Ao8jGWcNK5LC9z+8vE=
github.com/buildbarn/bb-storage v0.0.0-20260303071613-6002cad33537/go.mod h1:96kqnkrdkHHi94Agje3NM8qwrYMxJRSkAqsb7oXRhNI=
github.com/buildbarn/bb-storage v0.0.0-20260317135248-dc342e1799d7 h1:n6sJ9PxC6WSaLboSi3EcbIxfqgRd7tulb5hiep4kFh4=
github.com/buildbarn/bb-storage v0.0.0-20260317135248-dc342e1799d7/go.mod h1:96kqnkrdkHHi94Agje3NM8qwrYMxJRSkAqsb7oXRhNI=
github.com/buildbarn/go-sha256tree v0.0.0-20250310211320-0f70f20e855b h1:IKUxixGBm9UxobU7c248z0BF0ojG19uoSLz8MFZM/KA=
github.com/buildbarn/go-sha256tree v0.0.0-20250310211320-0f70f20e855b/go.mod h1:e7g3/yWApcg+PpDqd4eQEEV8pexQmfCgK3frP+1Wuvk=
github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU=
Expand Down
2 changes: 2 additions & 0 deletions pkg/proto/configuration/bb_remote_asset/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ proto_library(
"@com_github_buildbarn_bb_storage//pkg/proto/configuration/blobstore:blobstore_proto",
"@com_github_buildbarn_bb_storage//pkg/proto/configuration/global:global_proto",
"@com_github_buildbarn_bb_storage//pkg/proto/configuration/grpc:grpc_proto",
"@com_github_buildbarn_bb_storage//pkg/proto/configuration/zstd:zstd_proto",
],
)

Expand All @@ -27,6 +28,7 @@ go_proto_library(
"@com_github_buildbarn_bb_storage//pkg/proto/configuration/blobstore",
"@com_github_buildbarn_bb_storage//pkg/proto/configuration/global",
"@com_github_buildbarn_bb_storage//pkg/proto/configuration/grpc",
"@com_github_buildbarn_bb_storage//pkg/proto/configuration/zstd",
],
)

Expand Down
44 changes: 28 additions & 16 deletions pkg/proto/configuration/bb_remote_asset/bb_remote_asset.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions pkg/proto/configuration/bb_remote_asset/bb_remote_asset.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import "github.com/buildbarn/bb-storage/pkg/proto/configuration/auth/auth.proto"
import "github.com/buildbarn/bb-storage/pkg/proto/configuration/blobstore/blobstore.proto";
import "github.com/buildbarn/bb-storage/pkg/proto/configuration/global/global.proto";
import "github.com/buildbarn/bb-storage/pkg/proto/configuration/grpc/grpc.proto";
import "github.com/buildbarn/bb-storage/pkg/proto/configuration/zstd/zstd.proto";

option go_package = "github.com/buildbarn/bb-remote-asset/pkg/proto/configuration/bb_remote_asset";

Expand Down Expand Up @@ -50,6 +51,10 @@ message ApplicationConfiguration {

// Authorization policy for Push operations
buildbarn.configuration.auth.AuthorizerConfiguration push_authorizer = 11;

// ZSTD encoder/decoder pool configuration. When set, creates a
// process-wide pool shared by all gRPC CAS clients.
buildbarn.configuration.zstd.PoolConfiguration zstd_pool = 12;
}

message AssetCacheConfiguration {
Expand Down